Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for building andromeda testnet on local #99

Closed
wants to merge 4 commits into from

Conversation

dbeal-eth
Copy link
Contributor

accomplishes this by detecting the chain id of the currently building network. if its local, it replaces problematic oracle nodes with constant nodes

otherwise, the deployed network extremely closely resembles what is actually deployed to testnet, even after upgrades. this would be suitable for building a non-fork sandbox of any network (although right now its only tested with andromeda testnet)

@noahlitvin
Copy link
Contributor

Clever. I figured we'd have it use a local build of pyth/op-gas packages and create a new top-level cannonfile, but I like this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to swap the staleness circuit breaker node?

@leomassazza
Copy link
Contributor

leomassazza commented Dec 17, 2023

Is it possible to use a mock contract for the we cannot use in non-forked networks instead of changing the nodes architecture? That way the change is minimized (and more accurate to what is expected to happen in real networks) for local tests.

There's already a PR to introduce a mock for prebuilt ovm contract used here: Synthetixio/synthetix-v3#1963

accomplishes this by detecting the chain id of the currently building network. if its local, it replaces problematic oracle nodes with constant nodes

otherwise, the deployed network extremely closely resembles what is actually deployed to testnet, even after upgrades. this would be suitable for building a non-fork
sandbox of any network (although right now its only tested with andromeda testnet)
@noisekit noisekit force-pushed the andromeda-local-build-support branch from ee2a88c to d51127c Compare January 8, 2024 07:39
@dbeal-eth
Copy link
Contributor Author

Is it possible to use a mock contract for the we cannot use in non-forked networks instead of changing the nodes architecture? That way the change is minimized (and more accurate to what is expected to happen in real networks) for local tests.

There's already a PR to introduce a mock for prebuilt ovm contract used here: Synthetixio/synthetix-v3#1963

yes we can use a mock oracle instead just as easily. do oyu think you could get your PR merged upstream so we can implement it here more reliably?

@dbeal-eth dbeal-eth closed this Jun 3, 2024
@noisekit noisekit deleted the andromeda-local-build-support branch June 3, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants