-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arbitrage #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be an issue with making certain currencies unavailable. Probably stemming from updating values/fees, even though the logic seems sound. I'm looking into the issue, which probably existed beforehand, and do not want to merge until some headway is made into solving this.
…rdebook update, made arbitrage trade on a fixed value of profit, not %
…e when modifying unavailable_{self.quoted}
In principle I agree that this shouldn't be merged until those issues are dealt with, but I wonder if we could put that into a separate PR? Happy to keep it here if they were problems introduced by this patch, but if they were pre-existing then it would be good to get these arbitrageurs and other improvements into the master version. |
I think some of the issues did come with the changes here, so for now, I'll close this. |
_sell_quoted_
function;Closes #38.
Closes #3.