Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rounding where necessary, remove it where redundant. #31

Open
zyzek opened this issue Oct 17, 2017 · 0 comments
Open

Add rounding where necessary, remove it where redundant. #31

zyzek opened this issue Oct 17, 2017 · 0 comments

Comments

@zyzek
Copy link
Contributor

zyzek commented Oct 17, 2017

Not sure how much performance it's really consuming, but really the round_decimal function need only be called on products or quotients. Additive functions shouldn't matter, and neither should we need to call it for comparisons, if we are able to assume it's already been called when needed.

@zyzek zyzek changed the title Remove redundant rounding Add rounding where necessary, remove it where redundant. Oct 17, 2017
@0xdomrom 0xdomrom added High and removed simulation labels Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants