Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Floating point precision of values #13

Closed
0xdomrom opened this issue Oct 11, 2017 · 1 comment
Closed

Floating point precision of values #13

0xdomrom opened this issue Oct 11, 2017 · 1 comment
Labels
question

Comments

@0xdomrom
Copy link
Contributor

There should be a system of finite precision on all floating point values implemented, currently the system could end up having some level of floating point error. This should be a realistic number, as trading currencies to 18 decimal places is a bit over the top, somewhere in the range of 8-10 would probably be more than good enough.
@0xdomrom 0xdomrom changed the title Floating point precision of market bids Floating point precision of values Oct 11, 2017
@0xdomrom 0xdomrom mentioned this issue Oct 16, 2017
Closed
@0xdomrom
Copy link
Contributor Author

0xdomrom commented Oct 18, 2017 •
edited
Loading

Mostly solved in #23 new smaller issues to deal with problems arising from this approach #31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@0xdomrom