Fix pSTIR python tests #1276
Merged
Fix pSTIR python tests #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoid picking up pytest/unittest files. This is dangerous, but we shouldn't use this file anymore anyway AFAIK.
Had to rename 2 functions from test_* to *_tests to avoid pytest flagging up an error
KrisThielemans
force-pushed
the
fix_Python_tests
branch
from
96e01a4
to
ccd132f
Compare
|
I reverted (actually removed the commit) changing SIRF/src/xSTIR/pSTIR/tests/tests_two.py Lines 38 to 39 in 44ed358 On GHA, we get 718, while on my desktop I get 723. Not sure why. |
make test on norm of uniform image depend on computed result, not stored result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1275