Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorted out allocate methods (CIL/SIRF compatibility) #1222

Merged
merged 4 commits into from
Nov 22, 2023

Conversation

evgueni-ovtchinnikov
Copy link
Contributor

Changes in this pull request

Several allocate methods in STIR.py, Gadgetron.py and Reg.py are replaced with just one allocate in DataContainer class that does not copy data between Python and C++.

Testing performed

Related issues

Fixes #1212

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added docstrings/doxygen in line with the guidance in the developer guide
  • I have implemented unit tests that cover any new or modified functionality
  • The code builds and runs on my machine
  • CHANGES.md has been updated with any functionality change

Contribution Notes

Please read and adhere to the contribution guidelines.

Please tick the following:

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in SIRF (the Work) under the terms and conditions of the Apache-2.0 License.

Copy link
Member

@KrisThielemans KrisThielemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing code is always excellent!

src/common/SIRF.py Show resolved Hide resolved
src/common/SIRF.py Outdated Show resolved Hide resolved
src/common/SIRF.py Outdated Show resolved Hide resolved
src/common/SIRF.py Outdated Show resolved Hide resolved
src/common/SIRF.py Outdated Show resolved Hide resolved
@evgueni-ovtchinnikov evgueni-ovtchinnikov merged commit 1ab45d5 into master Nov 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImageData.allocate() does not support kw None for Gadgetron.and Reg
4 participants