Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add OSSPS set_relaxation_gamma #1204

Merged
merged 4 commits into from
Dec 7, 2023
Merged

add OSSPS set_relaxation_gamma #1204

merged 4 commits into from
Dec 7, 2023

Conversation

KrisThielemans
Copy link
Member

Fixes #1203.

@evgueni-ovtchinnikov I made a start with this. Would you be able to finish it off, and add a quick test?

@KrisThielemans KrisThielemans added this to the v3.6 milestone Jul 20, 2023
@evgueni-ovtchinnikov
Copy link
Contributor

testing: what value of gamma would be realistic and what effect to expect?

@KrisThielemans
Copy link
Member Author

https://stir.sourceforge.net/documentation/doxy/html/classstir_1_1OSSPSReconstruction.html says alpha~1 and and gamma ~ .1. Those are the defaults in STIR, so I guess SIRF. Higher gamma means slower convergence (as step-size goes down), but more subset fluctuations.

In any case, I think the test could simply be to set and then get.

Bu the way, there's an upper_bound that would also be useful to expose.

KrisThielemans
KrisThielemans commented Nov 23, 2023
View reviewed changes
Copy link
Member Author

@KrisThielemans KrisThielemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to update CHANGES.md

KrisThielemans
KrisThielemans commented Dec 6, 2023
View reviewed changes
Copy link
Member Author

@KrisThielemans KrisThielemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. ready to merge I guess!

@evgueni-ovtchinnikov evgueni-ovtchinnikov merged commit 058232b into master Dec 7, 2023
6 checks passed
@evgueni-ovtchinnikov evgueni-ovtchinnikov deleted the OSSPS_gamma branch December 7, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@evgueni-ovtchinnikov evgueni-ovtchinnikov

Labels
None yet
Projects
None yet
Milestone
v3.6
Development

Successfully merging this pull request may close these issues.

OSSPSReconstructor should expose set_relaxation_gamma, and have get_* functions
2 participants
@KrisThielemans @evgueni-ovtchinnikov