feat(accountsdb,gossip): Initial snapshot propagation work #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
InKryption
force-pushed
the
ink/send-snapshots
branch
8 times, most recently
from
fff94e2
to
1480030
Compare
|
Interesting failure on the CI: https://github.com/Syndica/sig/actions/runs/11614796242/job/32343808753?pr=333 |
InKryption
force-pushed
the
ink/send-snapshots
branch
from
f4aec7b
to
c98d339
Compare
InKryption
changed the title
InKryption
commented
Oct 31, 2024
|
I still want to try resolve that TODO, but the code should now be in a state that's suitable for review. |
|
Alright there ended up being a simple workaround for the time being. |
InKryption
force-pushed
the
ink/send-snapshots
branch
from
6250b72
to
f631824
Compare
InKryption
force-pushed
the
ink/send-snapshots
branch
from
f631824
to
f9d39c7
Compare
InKryption
force-pushed
the
ink/send-snapshots
branch
from
f9d39c7
to
d01918d
Compare
0xNineteen
requested changes
Nov 4, 2024
InKryption
force-pushed
the
ink/send-snapshots
branch
2 times, most recently
from
7bbd6ed
to
b27f6ac
Compare
Sobeston
requested changes
Nov 6, 2024
There was a problem hiding this comment.
Haven't touched gossip yet so can't be 100% on that, but all seems good.
I like the additional comments and InitParams on accountsdb.
One thing that I haven't marked:
- should we be prefixing optional fields with
maybe_like we do for vars and consts? e.g.- geyser_writer
- gossip_push_msg_queue
1. Guard the full and incremental snapshot info under the same rwmux, both to deduplicate the full slot value, and to synchronize the existence of incremental snapshots relative to full snapshots. 2. Also do the same with the first snapshot info.
* Grouped fields into a few categories. * Change init to take only an `InitParams` struct. * Lowercase `AllocatorConfig` fields. * Share the `AllocatorConfig` enum tag across a few different places. * Inline `InitConfig`'s fields and remove it. * Fix code that potentially leaked a disk allocator pointer.
It was incorrectly reporting `file_info.length` as the file size, when it should have been using `account_file.memory.len`. This also adds a couple more runtime checks to assert the total written bytes are aligned to full 512 byte blocks.
It's currently disabled because it overwrites the snapshot archives in the test data dir; can comment the skip statement in order to test it locally for now. As the TODO says, we need a mechanism for loading from a snapshot which isn't in the accountsdb's snapshot working directory. This also adds a simple way to test the equality of the `SnapshotHashes` structure in tests.
The potential memory savings were minimal at best, and came at a significant cost in complexity - a simple tagged union is sufficient to avoid the overhead of an allocation, whilst retaining simplicity across the rest of the code (especially wrt generic comparisons).
Sequence it before deinit
In the future there should be a better API for loading from a snapshot that's outside the accountsdb snapshot working directory.
* Refactor `initSigned`, and related init methods, and call sites. * Move methods into more scoped types. * Flatten the `Gossip` struct into `AccountsDB`, and only store `my_pubkey`, instead of the whole key pair. * Change `push_msg_queue` to queue unsigned gossip data, and then sign it in `drainPushQueueToGossipTable`. * Set the wallclock time in `drainPushQueueToGossipTable` as well.
InKryption
force-pushed
the
ink/send-snapshots
branch
from
2d5918e
to
5de9f2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change set is centered around advertising snapshot generation to gossip, which in and of itself is not huge. It comes with a myriad of satellite refactors, improvements, and bug fixes which I encountered while I was in the process of testing/integrating the change in a smooth way, as well as experiments in setting up the RPC server for serving the advertised snapshots, which will instead be done in a follow-up PR.