Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EJ2-68390 : Functional snippet changes in SB for React platform #6

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

ghost
Copy link

@ghost ghost commented Apr 11, 2023

Description

GitHub samples in react documentation are changed from class component to functional component

@ghost ghost self-assigned this Apr 12, 2023
@ghost ghost requested a review from johnsonmanickam April 12, 2023 03:55
@ghost ghost changed the title EJ2-68390-functional EJ2-68390 : Functional snippet changes in SB for React platform Apr 14, 2023
@ghost ghost added the documentation Improvements or additions to documentation label May 2, 2023
@@ -25,26 +26,25 @@ public PdfViewerController(IHostingEnvironment hostingEnvironment, IMemoryCache
}

[HttpPost("Load")]
[Microsoft.AspNetCore.Cors.EnableCors("MyPolicy")]
/* [Microsoft.AspNetCore.Cors.EnableCors("MyPolicy")]*/
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we comment on this line?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the commented tags are removed

@ghost
Copy link

ghost commented May 16, 2023

@SaravanaPriya31 Why are there so many unwanted files added in this PR https://github.com/SyncfusionExamples/react-pdf-viewer-examples/pull/6/files, Make sure this sample should contain the necessary files and should be a simple one for the customer. 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Development

Successfully merging this pull request may close these issues.

1 participant