Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict login endpoint when public login disallowed #1592

Merged
merged 2 commits into from
Dec 15, 2024
Merged

Restrict login endpoint when public login disallowed #1592

merged 2 commits into from
Dec 15, 2024

Conversation

cjmyers
Copy link
Collaborator

@cjmyers cjmyers commented Dec 14, 2024

closes #1557

@cjmyers cjmyers requested a review from danielfang97 December 14, 2024 22:00
@cjmyers cjmyers mentioned this pull request Dec 14, 2024
Closed
danielfang97
danielfang97 approved these changes Dec 15, 2024
View reviewed changes
Copy link
Collaborator

@danielfang97 danielfang97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested first without changes and /register still accessible. Now, with changes, can't access /register anymore.

@cjmyers cjmyers merged commit 406456a into master Dec 15, 2024
4 checks passed
@cjmyers cjmyers deleted the restrictRegister branch December 15, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielfang97 danielfang97 danielfang97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should not be able to access /register endpoint when public account creation disabled
2 participants
@cjmyers @danielfang97