-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix problem with editing types #1591
Conversation
I tried to input in a circular type to a part, but I think I did it wrong, and it threw an error. It can no longer access the part at all. I think when an improper type is added, it should throw an error and try to allow you to change it. Not break the part completely. |
What I'm saying, it should be easier to add/edit a type. People may not know the exact way to do it. |
The inability to access the part after enter a bad type is exactly the error I was trying to fix here. Could you verify that you tested this on this branch. I thought I had fixed that behavior. |
Just tested and it appears to no longer throw the error. However, there is a new bug where if you leave the box blank, it remains there. Blank should be treated the same as a wrong type. |
I think that bug was there before too, I can log a new issue for that |
So, should I just approve this one? Or are we adding an issue to this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected. Now, it doesn't throw an error
closes #1566