Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem with editing types #1591

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Fix problem with editing types #1591

merged 4 commits into from
Dec 17, 2024

Conversation

cjmyers
Copy link
Collaborator

@cjmyers cjmyers commented Dec 14, 2024

closes #1566

@cjmyers cjmyers requested a review from danielfang97 December 14, 2024 21:42
@danielfang97
Copy link
Collaborator

I tried to input in a circular type to a part, but I think I did it wrong, and it threw an error. It can no longer access the part at all. I think when an improper type is added, it should throw an error and try to allow you to change it. Not break the part completely.

@danielfang97
Copy link
Collaborator

What I'm saying, it should be easier to add/edit a type. People may not know the exact way to do it.

@cjmyers
Copy link
Collaborator Author

cjmyers commented Dec 15, 2024

The inability to access the part after enter a bad type is exactly the error I was trying to fix here. Could you verify that you tested this on this branch. I thought I had fixed that behavior.

@danielfang97
Copy link
Collaborator

Just tested and it appears to no longer throw the error. However, there is a new bug where if you leave the box blank, it remains there. Blank should be treated the same as a wrong type.

@cjmyers
Copy link
Collaborator Author

cjmyers commented Dec 17, 2024

I think that bug was there before too, I can log a new issue for that

@danielfang97
Copy link
Collaborator

So, should I just approve this one? Or are we adding an issue to this PR?

Copy link
Collaborator

@danielfang97 danielfang97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Now, it doesn't throw an error

@cjmyers cjmyers merged commit 1f82cf9 into master Dec 17, 2024
4 checks passed
@cjmyers cjmyers deleted the fixEditTypes branch December 17, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to add circular type
2 participants