minor: fix tests for url-safe signed urls #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbond
force-pushed
the
url-safe-signed-uris
branch
from
5b152ad to
f44aedc
Compare
bocharsky-bw
approved these changes
Jan 15, 2025
| true | ||
| $actual = $components->getSignedUrl(); | ||
| $expected = $testHelper->uriSigner->sign(\sprintf( | ||
| 'http://localhost/verify/user?expires=%s&token=%s', |
There was a problem hiding this comment.
hm, why no port? Do we run it w/o port on CI? Will it fail if we run it with port locally?
There was a problem hiding this comment.
This is the default for Symfony, without any modifications, http://localhost is the base url. So yes, it passes locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
symfony/symfony#59022 changed how signed urls are encoded. This change to the tests is required for 7.3+.