Allow version configuration #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -115,6 +116,6 @@ public function getOutputCssContent(): string | |||
|
|
|||
| private function createBinary(): TailwindBinary | |||
| { | |||
| return new TailwindBinary($this->tailwindVarDir, $this->projectRootDir, $this->binaryPath, $this->output); | |||
| return new TailwindBinary($this->tailwindVarDir, $this->projectRootDir, $this->binaryPath, $this->binaryVersion, $this->output); | |||
There was a problem hiding this comment.
Hm, this will introduce a possible BC break, though not sure if we can neglect it and mention in the release, it's convenient to have those 2 args close to each other
There was a problem hiding this comment.
TailwindBinary is basically internal,, so mentioning it in the release is OK i guess.
Co-authored-by: Victor Bocharsky <[email protected]>
|
We started having some randomly failing tests on Windows... do you have any ideas to make that stable? Looks like a permissions issue :/ |
Sorry. Not a clue... |
bocharsky-bw
approved these changes
Dec 15, 2023
Co-authored-by: Victor Bocharsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #34 as discussed there in the comments