Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect width of insn_funct6 in I-type (shift variation) instruction format? #42

Open
DonaldKellett opened this issue Aug 6, 2020 · 0 comments

Comments

@DonaldKellett
Copy link

In the I-type (shift variation) instruction format (e.g. insns/insn_slli.v), the insn_funct6 field is defined as follows:

wire [6:0] insn_funct6 = rvfi_insn[31:26];

That is, while insn_funct6 is declared as a 7-bit field, it is assigned a 6-bit value. Also, in line 46 of the same file, we have insn_funct6 == 6'b 000000 as a subexpression which further suggests that insn_funct6 is treated as a 6-bit value for all intents and purposes.

I suppose this is unintentional, or am I missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant