This repository has been archived by the owner on Aug 3, 2018. It is now read-only.
Fix document type hinting #97
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
einorler
force-pushed
the
fix-document-type-hinting
branch
3 times, most recently
from
74120a2
to
a45e9d7
Compare
einorler
force-pushed
the
fix-document-type-hinting
branch
from
a45e9d7
to
c6640d6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've took some closer look on the case of collection type hinting. Firstly, the setter is mandatory, so sorry for my previous comment, secondly ONGR collection class is deprecated and not recommended anymore, in stead I changed the type hinting to use
Doctrine\Common\Collections\Collectioninterface, because this includes bothDoctrine\Common\Collections\ArrayCollectionthat is recommended by the ONGR collection deprecation message (see here: https://github.com/ongr-io/ElasticsearchBundle/blob/a2642ee9549f3906f2d22d88479364ccc1a542f9/Collection/Collection.php#L19) andONGR\ElasticsearchBundle\Result\ObjectIteratorthat ONGR ES bundle uses when lazy loading the results after search.However, this is a potential place to pay close attention to in the future, because I contacted the maintainer of the ONGR project and I was informed that this is a known issue in ONGR ES bundle and will be attended to in the comming months.
Closes #95