Allow Symfony 6 #32
Closed
Allow Symfony 6 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loevgaard
commented
Oct 10, 2023
| @@ -7,9 +7,6 @@ on: | |||
| pull_request: ~ | |||
| release: | |||
| types: [created] | |||
| schedule: | |||
There was a problem hiding this comment.
Removed this because it has this unintended consequence:
loevgaard
force-pushed
the
sf6
branch
3 times, most recently
from
1d2a2ee
to
7939ee2
Compare
Rafikooo
approved these changes
Oct 10, 2023
diimpp
approved these changes
Oct 10, 2023
|
Hello |
|
@pierre-dedi: It's not impossible, but almost. This bundle depends on https://github.com/FriendsOfSymfony/FOSOAuthServerBundle which is more or less dead and doesn't support SF6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR needs some more work. We are blocked by the oauth package which only supports SF5. I will need to devise a BC layer to make this work in a minor. Will look more into this next week or in two weeks.