Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort Savegames by system in internal storage #690

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

newhinton
Copy link

@newhinton newhinton commented Jul 15, 2023

This will create a folder for each system in internal memory. Other emulator-applications usually seperate savegames by their system name. When the internal storage is now synced to external ones, they are not "compatible" with those applications. (I mainly refer to how retropie handles this).

The changes work like this:

  1. Core loads savegame.
  2. Savegame-file is detected as usual.
  3. SavegameManager checks if a system/savename.srm-file exists
  4. returns that if it is not empty
  5. return legacy-save if it is empty.

Saving:

  1. Save like usual, except use system/savename.srm-scheme
  2. check if file has been written, and if legacy file exists.
  3. If legacy file exists, delete it

This is really only useful with #632

Edit:

Since i am deleting savegames, this PR should be tested extensively. I can also remove the deletion and just keep the internal storage "cluttered", it shouldn't matter that much storage-wise.

Copy link

@x64x2 x64x2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really necessary?

@newhinton

This comment was marked as duplicate.

@newhinton
Copy link
Author

newhinton commented Aug 10, 2023

@s0mt0chukwu Necessary? Probably not.

However: Most other emulator-packages (like RetroPie) do use such a sorted folderstructure.

This PR is probably pointless and useless if used standalone, since all the savegames are inaccessible on internal storage. But my own build combines this with all of my other PR's, especially #632, which makes this a really nice addition since i have sorted savegames synced to the cloud-provider of my choice. Without this PR it is an unsorted mess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants