Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parallel #255

Merged
merged 19 commits into from
Oct 10, 2019
Merged

Parallel #255

merged 19 commits into from
Oct 10, 2019

Conversation

dhardy
Copy link
Collaborator

@dhardy dhardy commented Oct 10, 2019

Works towards #204 by switching to per-human random number generators.

Does not complete this effort; at least two issues remain (but even with these solved I can't make tests pass):

  • some monitoring measures are reported during updates, thus need to lock / use mutexes
  • tsAdultEntoInocs and tsNumAdults static vars are updated within TransmissionModel::getEIR

dhardy added 19 commits September 6, 2019 13:35
@dhardy
RNG: remove MT19937 support
1460342 
This was already disabled but would cause some issues with parallelisation
plans due to its size, hence there is no reason to keep this code.
@dhardy
RNG: remove static uniform distribution
fe3eaf2 
This makes it possible to pass the generator into functions.
No significant performance impact
@dhardy
Revise RNG code: make generator explicit
142b5a3 
This is transitional work towards multiple RNGs,
enabling parallelisation.
@dhardy
Add chacha RNG with tests
b019fdf
@dhardy
chacha: add unique IV
2c7e368
@dhardy
PCG: remove unused code
de3d184
@dhardy
RNG: new checkpointing code; remove seed and checkpoint ctors
7e39e66
@dhardy
Make random::RNG generic over RNG type
f0bdf9a
@dhardy
Add ChaCha<8> master_RNG in parallel with global_RNG
94b7e1e
@dhardy
Update git ignore / project files
3416a20
@dhardy
Add local RNG to human; pass to WithinHost code
66ee1ed 
No changes to which RNG is used; tests pass
@dhardy
Pass local RNG to Clinical and remaining WithinHost code
212b9b1 
No changes to which RNG is used; tests pass
@dhardy
Pass local RNG to remaining model code
0ade9e7 
No changes to which RNG is used; tests pass
@dhardy
Remove use of global_RNG from unit tests, where possible
85b601f
@dhardy
Use 128-bit seeds for all RNGs
66b66dd 
This has very low cost and significantly reduces the chance
of two local RNGs overlapping part of their period.
@dhardy
Use local RNGs and update output
60578d9
@dhardy
Remove global_RNG and random.cpp; update random.h doc
8cc103e
@dhardy
Revise human update loop
c59bfc6
@dhardy
Population: store humans in a vector, not a list
67c312d 
Small performance improvement
@dhardy dhardy merged commit d5502b8 into SwissTPH:master Oct 10, 2019
@dhardy dhardy mentioned this pull request Oct 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dhardy