feat: [#18] Adding Mongolian translation #37
Conversation
Conflicts: json_text.js
Conflicts: json_matrix.js json_text.js
Replaced all TODO MN texts in mongolian translation
…-Health-Effects into feature/18-mongolian
|
Hi @Nara1469 Works perfectly on technical level, thanks a lot for your diligent work of integrating the translation so nicely. Of course I can't read nor understand the new content, so I cannot comment on that at all :-) One thing we noticed with other translations added on top of the initial 4 languages: The layout chosen initially does not always match the space requirements of additional languages, so it's sometimes very challenging to fit new translations into the geometric shapes nicely. With mongolian e.g. here: I trust you already tried to make it fit - and if so, I guess it's fine. If not, however, would the mongolian language allow to either abbreviate or hyphenate some of the longer words? Please let us know if you see some room for improvement and plan to provide some fine-tuning on that front. In any case, I'll pass it on to Meltem for review before merging. |
|
Dear Urs,
Thanks for your nice review and immediate response. I agree on Mongolian
translation and naming are tend to be more longer than the initial 4
languages. Our team is still working on word choice with health care
specialists. This our is first PR, and we will review our side testing.
I’d like to ask, how can we see the Mongolian translated figure for the
review before or after merging? Please send me the links, if possible.
Thanks again for your support and your team. We’re thrilled to cooperate
with your project spread the knowledge and education.
Best regards,
Nara Davaasuren
BreatheMongolia Development Team
…On Sun, Jun 30, 2024 at 11:10 PM Urs Joss ***@***.***> wrote:
Hi @Nara1469 <https://github.com/Nara1469>
Works perfectly on technical level, thanks a lot for your diligent work of
integrating the translation so nicely.
Of course I can't read nor understand the new content, so I cannot comment
on that at all :-)
One thing we noticed with other translations added on top of the initial 4
languages: The layout chosen initially does not always match the space
requirements of additional languages, so it's sometimes very challenging to
fit new translations into the geometric shapes nicely. With mongolian e.g.
here:
image.png (view on web)
<https://github.com/SwissTPH/AP-Health-Effects/assets/357238/ab5aff8e-f46f-46fb-8c47-a89da4e7c159>
I trust you already tried to make it fit - and if so, I guess it's fine.
If not, however, would the mongolian language allow to either abbreviate or
hyphenate some of the longer words? Please let us know if you see some room
for improvement and plan to provide some fine-tuning on that front.
In any case, I'll pass it on to Meltem for review before merging.
—
Reply to this email directly, view it on GitHub
<#37 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWSYEDWQ5W2AKZ4KZTA7VYTZKDQDLAVCNFSM6AAAAABKEXTNXOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJZGI2DQNJVGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Dear Nara That sounds like an exellent plan. Thanks for your quick response. In order to test the translation, you can open In order to see it in the live version (https://www.swisstph.ch/de/projects/ludok/healtheffects), we'll need to merge your PR (or PRs) and deploy the resulting version from the It may well be possible that after actual deployment you'll find a reason to fix something that should be improved (be it formally or because of new insights scientifically). There's always an option to create additional PRs in the future. Hope this helps, best regards |
|
Dear Nara I added an additional commit to the original PR #19 : 79ed5cf. It fixes the visibility of the still birth bullet point that is only visible in the Mongolian translation. Please update your branch by rebasing or merging from the original branch or alternatively cherry-pick the commit into your branch. Thanks, Urs |
|
Thanks, I'll check it out!
…On Mon, Jul 1, 2024 at 10:28 AM Urs Joss ***@***.***> wrote:
Dear Nara
I added an additional commit to the original PR #19
<#19> : 79ed5cf
<79ed5cf>.
It fixes the visibility of the still birth bullet point that is only
visible in the Mongolian translation.
Please update your branch by rebasing or merging from the original branch
or alternatively cherry-pick the commit into your branch.
—
Reply to this email directly, view it on GitHub
<#37 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWSYEDXNUDX4QQXVN5T7SBTZKF7RDAVCNFSM6AAAAABKEXTNXOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBQGU4DCNZWGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I got the OK to merge this PR after an email correspondance between Aza and Meltem. I'll cherry-pick the missing commit after the merge. Thanks. |
Added Mongolian translation
Resolves #18