Add support for lambda expressions instead of json path for ignore and accept #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Kudos, SonarCloud Quality Gate passed! |
nscheibe
reviewed
Mar 20, 2023
| @@ -97,5 +97,18 @@ public void MatchSnapshot_Null_Throws() | |||
| // act & assert | |||
| Assert.Throws<ArgumentNullException>(() => testPerson.MatchSnapshot()); | |||
| } | |||
|
|
|||
| [Test] | |||
| public void MatchSnapshot_ShouldFluentAssertionsWithLambda_RemovesSubject() | |||
There was a problem hiding this comment.
In NUnit it does not create a accept. and the ignore we dont know yet.
| public void MatchSnapshot_ShouldFluentAssertions_RemovesSubject() | ||
| { | ||
| // arrange | ||
| TestPerson testPerson = TestDataBuilder.TestPersonMarkWalton().Build(); |
There was a problem hiding this comment.
Try to add random input for accepted and ignored fields
src/Snapshooter/Snapshooter.csproj
Outdated
| @@ -14,6 +14,7 @@ | |||
| </PropertyGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="FluentAssertions" Version="6.7.0" /> | |||
There was a problem hiding this comment.
I think we should discuss if we want to have a fluent assertions reference within snapshooter (project) or if we can create a snapshooter.fluentassertions or so...
| @@ -0,0 +1,56 @@ | |||
| { | |||
| "Id": "c78c698f-9ee5-4b4b-9a0e-ef729b1f8ec8", | |||
| "Firstname": "Mark", | |||
RohrerF
force-pushed
the
assertions-with-lambda-expressions
branch
from
ac40e1f
to
21c9d8f
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using fluent assertions, e.g.
person.Should().MatchSnapshot()or the static snapshot class, e.g.Snapshot.Match(person)a generic overload now ensures that we can use lambda expressions to accept and ignore fields.Examples: