Use zipfoundation for unzip #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI tests are still broken but I know why now: https://forums.swift.org/t/amazon-linux-2023-support/66209/10 Linux test run: macOS test run: |
daveverwer
approved these changes
Jul 11, 2024
finestructure
force-pushed
the
use-zipfoundation-for-unzip
branch
from
9f1b569
to
91d2f35
Compare
|
Will deploy this and test swift-metrics doc gen next week after we're done with Xcode 16b3 processing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SwiftPackageIndex/SwiftPackageIndex-Server#3137
I ended up having to go with open 2. from the above issue,
having explored all other options, including, most recently, deploying not a Lambda binary to the provided Lambda runtime but shipping our own container with
unzipinstalled.However, this would be a very disruptive and risky change, because a stack cannot be updated in place from a provided runtime to a custom image runtime. The stack has to be deleted and recreated.
It would also mean having to use a container registry where we host the 600 MB images, which we need to build and push - vs the 30 MB binary zip we currently deploy.
I went through the motions of doing it and it's just too massive a change to the setup and how we deploy for fixing a single repos zip file issue, especially when there's a much simpler, albeit somewhat ugly, solution available.