Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for explicit SSH port. #23

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

toponim
Copy link

@toponim toponim commented Sep 23, 2024

PR to address issue: #21.

@toponim toponim marked this pull request as ready for review September 23, 2024 10:29
@cyberw
Copy link
Collaborator

cyberw commented Sep 23, 2024

Can you make it so that the -p (portnumber) is only added to the command when port is actually set? Dont wanna make that already very long command any longer for what is a rare use case...

@toponim
Copy link
Author

toponim commented Sep 24, 2024

Changed solution a little, please note that resulted command line in some cases would have doubled whitespace but code looks cleaner and nicer to me in such solution so I guess that shouldn't be a problem. Please make me know if you considering this as an issue.

@cyberw cyberw merged commit eea2bd8 into SvenskaSpel:master Sep 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants