-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/graphql chapter pages mutation handle downloaded chapters #665
Feature/graphql chapter pages mutation handle downloaded chapters #665
Conversation
3965c0d
to
9f9e5f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to avoid getChapterDownloadReady unless its optimized, it does a lot of unneeded database queries
9f9e5f7
to
42a986c
Compare
In case the chapter is downloaded, fetching the chapter pages info should not be needed. It should also currently break reading downloaded chapters while being offline, since the page request will always fail, since there is no internet connection
42a986c
to
266bc4c
Compare
I updated I think it would be best to decouple logic like this. then you have one place which handles e.g. in this case getting the chapter pages. |
The goal is to have GraphQL be as optimized as possible, while sharing code between it and the old Rest API is fine, its secondary since we don't plan to improve the Rest API in the future. When we drop the REST api we will drop a bunch of old code as well, anything that is not used by the GraphQL api will be removed, allowing us to further optimize the GraphQL api. |
No description provided.