Fix some settings not being applied properly #661
Conversation
| @@ -62,7 +62,8 @@ object ProtoBackupExport : ProtoBackupBase() { | |||
| timeOfDay | |||
| ) | |||
| }, | |||
| ::scheduleAutomatedBackupTask | |||
| ::scheduleAutomatedBackupTask, | |||
| ignoreInitialValue = false | |||
There was a problem hiding this comment.
does this work?
I think I started the interval in the ServerSetup because the ProtoBackupExport never gets loaded unless a backup gets created
There was a problem hiding this comment.
It should, objects are statically initialized
There was a problem hiding this comment.
Though I see now that they are initialized in ServerSetup, so I'll revert these ones
There was a problem hiding this comment.
I think I confused it with the Updater, because that only gets initialized lazily, so I just didn't change it like this when I added the server setting subscription
| @@ -79,7 +79,7 @@ fun applicationSetup() { | |||
| } else { | |||
| setLogLevel(Level.INFO) | |||
| } | |||
| }) | |||
| }, ignoreInitialValue = false) | |||
There was a problem hiding this comment.
is this
// set log level early
if (debugLogsEnabled(config)) {
setLogLevel(Level.DEBUG)
}
still needed in the ConfigManger with this change?
I believe the issue with the debug logs is because I forgot to set the default log level, which was INFO before in the logback config file, when I added the file logging
There was a problem hiding this comment.
I think it still is, configs would get initialized and there are some logs in the config manager that should be outputted
| @@ -53,7 +53,7 @@ class Updater : IUpdater { | |||
| private var currentUpdateTaskId = "" | |||
|
|
|||
| init { | |||
| serverConfig.subscribeTo(serverConfig.globalUpdateInterval, ::scheduleUpdateTask) | |||
| serverConfig.subscribeTo(serverConfig.globalUpdateInterval, ::scheduleUpdateTask, ignoreInitialValue = false) | |||
There was a problem hiding this comment.
The interval also gets started in the ServerConfig
I think I did it that way for the same reason as for the backup interval
No description provided.