Feature/move server frontend mapping to the frontend #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schroda
force-pushed
the
feature/move_server_frontend_mapping_to_the_frontend
branch
3 times, most recently
from
9ac3f68
to
382adf7
Compare
schroda
force-pushed
the
feature/move_server_frontend_mapping_to_the_frontend
branch
from
382adf7
to
cac6b75
Compare
schroda
force-pushed
the
feature/move_server_frontend_mapping_to_the_frontend
branch
5 times, most recently
from
14bd291
to
17c2a15
Compare
Syer10
requested changes
Jul 16, 2023
server/src/main/kotlin/suwayomi/tachidesk/server/util/WebInterfaceManager.kt
Outdated
Show resolved
Hide resolved
schroda
force-pushed
the
feature/move_server_frontend_mapping_to_the_frontend
branch
from
c258adf
to
96bc901
Compare
not yet, I'll ping you when it's ready I updated the automated webUI update check to use the "HAScheduler" |
schroda
force-pushed
the
feature/move_server_frontend_mapping_to_the_frontend
branch
from
96bc901
to
891cd73
Compare
schroda
force-pushed
the
feature/move_server_frontend_mapping_to_the_frontend
branch
from
891cd73
to
531705d
Compare
|
I added a function to get the latest version of the webUI preview, instead of having to change the naming pattern of the bundled webUI zip file from |
|
webUI repo is up-to-date |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the webUI requires a server release.
This PR enables the webUI to do its own releases by adding the functionality to the server to download the latest webUI version.
The webUI defines which webUI version is compatible with which server version.
Thus, the server can download the latest compatible version based on its version.
The mapping of webUI version to server version is a file inside the webUI repo.
This file gets updated each time a new webUI version gets released which requires a newer server version than the previous release.
example:
In this example
This does not change the current behaviour of the server release bundling a webUI version.
This version is still used as a fallback in case everything else fails.
How the server will setup the webUI:
download result handling:
Support for different webUIs is also added.
As long as they fullfill the required conditions, e.g. version mapping file in correct format, available version downloads, they can be defined in the server to be provided as an optional webUI that can be used.
In case the server runs into issues with one of these webUIs (e.g. download not possible) it will fallback to the default webUI