Feature/decouple thumbnail downloads and cache #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schroda
force-pushed
the
feature/decouple_thumbnail_downloads_and_cache
branch
from
7e88930
to
8c682d4
Compare
AriaMoradi
previously requested changes
Jun 24, 2023
server/src/main/kotlin/suwayomi/tachidesk/manga/impl/util/storage/ImageResponse.kt
Outdated
Show resolved
Hide resolved
| @@ -331,13 +331,24 @@ object Chapter { | |||
| } | |||
| } | |||
|
|
|||
| private fun deleteFilesOf(chapterIds: List<Int>, mangaId: Int) { | |||
There was a problem hiding this comment.
choose a better name for this function
There was a problem hiding this comment.
renamed it to deleteDownloadsFor
.../main/kotlin/suwayomi/tachidesk/manga/impl/download/fileProvider/IDownloadedFilesProvider.kt
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| @FunctionalInterface | ||
| interface IFileDownload1<A> : IFileDownload { |
There was a problem hiding this comment.
make up better names instead of numbering
There was a problem hiding this comment.
tbh, no clue how to name this, I added "Args" as an suffix
I'm open for better names
| fun getChapterDownloadPath(mangaId: Int, chapterId: Int): String { | ||
| return applicationDirs.mangaDownloadsRoot + "/" + getChapterDir(mangaId, chapterId) | ||
| return applicationDirs.downloadsRoot + "/mangas/" + getChapterDir(mangaId, chapterId) |
There was a problem hiding this comment.
added mangaDownloadsRoot to app dirs
There was a problem hiding this comment.
also we should use a sensible path joiner function instead of hand concatenating them
schroda
force-pushed
the
feature/decouple_thumbnail_downloads_and_cache
branch
from
8c682d4
to
57d9aac
Compare
schroda
changed the title
schroda
force-pushed
the
feature/decouple_thumbnail_downloads_and_cache
branch
3 times, most recently
from
01d9723
to
789a6e8
Compare
schroda
changed the title
schroda
force-pushed
the
feature/decouple_thumbnail_downloads_and_cache
branch
from
789a6e8
to
31b1bca
Compare
schroda
force-pushed
the
feature/decouple_thumbnail_downloads_and_cache
branch
from
31b1bca
to
4fdbc05
Compare
Syer10
reviewed
Jul 23, 2023
server/src/main/kotlin/suwayomi/tachidesk/graphql/mutations/MangaMutation.kt
Outdated
Show resolved
Hide resolved
schroda
force-pushed
the
feature/decouple_thumbnail_downloads_and_cache
branch
from
4fdbc05
to
bf65476
Compare
schroda
force-pushed
the
feature/decouple_thumbnail_downloads_and_cache
branch
from
bf65476
to
39d3dcb
Compare
Syer10
requested changes
Aug 5, 2023
server/src/main/kotlin/suwayomi/tachidesk/graphql/mutations/MangaMutation.kt
Show resolved
Hide resolved
server/src/main/kotlin/suwayomi/tachidesk/manga/impl/util/storage/SafePath.kt
Outdated
Show resolved
Hide resolved
schroda
force-pushed
the
feature/decouple_thumbnail_downloads_and_cache
branch
from
39d3dcb
to
8e487cc
Compare
Syer10
requested changes
Aug 10, 2023
schroda
force-pushed
the
feature/decouple_thumbnail_downloads_and_cache
branch
2 times, most recently
from
e5c5720
to
cb1acd5
Compare
When adding/removing manga from/to the library make sure the permanent thumbnail files will get handled properly
schroda
force-pushed
the
feature/decouple_thumbnail_downloads_and_cache
branch
from
cb1acd5
to
c791f1b
Compare
Syer10
approved these changes
Aug 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all thumbnails are downloaded permanently.
This not only includes thumbnails of mangas that are part of the library but also when browsing a source.
Unless you manually cleanup these files, they will never get deleted.
This PR changes thumbnails to be tmp files, which get saved in the systems tmp folder.
Only thumbnails of mangas, that are part of the library, will be saved permanently.
Once a manga gets added/removed from the library, the permanent thumbnail will get downloaded/deleted.
The logic for this reuses the existing logic of the chapter pages.
There had to be slight adaptions to the interface and classes since the functions for the thumbnails and pages have different number of arguments.
Since they are still classes which have to provide the same behaviour with the same functions (e.g. get image, download image, delete image) I wanted to use the same interface
In case the tmp files should not get saved in the systems tmp folder, this can be changed in a later/separate PR which implements a custom cache (which IMO then should also be used for the pages of chapters)