Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it compatible with kaminari 1.0 #150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make it compatible with kaminari 1.0 #150

wants to merge 1 commit into from

Conversation

Kitton
Copy link

@Kitton Kitton commented Jan 18, 2017 •
edited
Loading

In kaminari 1.0 they removed method deprecated num_pages in favor of total_pages. Issue: #148

@Sutto
Copy link
Owner

Sutto commented Mar 15, 2017

Sorry I've only now just gotten this - Since this adds a min requirement on kaminari, I'll bump our version as well and aim to get this out shortly.

@avitus
Copy link

avitus commented Jun 21, 2017

Any chance we can get this merged in? It seems to be an easy fix.

@montdidier montdidier mentioned this pull request May 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kitton @Sutto @avitus