Scale parallax layers perspectively-correctly #2954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobbi
reviewed
May 28, 2024
tobbi
changed the title
mrkubax10
added
type:patch
category:code
status:needs-review
mrkubax10
reviewed
Jun 15, 2024
MatusGuy
reviewed
Jul 13, 2024
|
Could you sync your branch so I can make use of the portable zip for windows builds please? Makes it more convenient for me to test |
Frostwithasideofsalt
approved these changes
Jul 15, 2024
tobbi
reviewed
Jul 15, 2024
tobbi
reviewed
Jul 15, 2024
mrkubax10
removed
the
status:needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented it for both tilemaps and backgrounds. DEMO: https://www.youtube.com/watch?v=GnFArTYBL4E
Scaling now works so that it imitates a perspective camera. The layers scale differently based on their scrolling speed.
Also note that the z-position based on which the scaling is calculated, does not depend on the "z-pos" value at all, so it is nicely compatible with the old levels.
It also fixes the bug which allows players to see around paralax layers when the viewport is scaled down. If the layer is large enough to cover the level in the default scale, it now works in all scales.