Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix swimming on slopes #2886

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Conversation

MatusGuy
Copy link
Member

@MatusGuy MatusGuy commented Apr 2, 2024

No description provided.

@MatusGuy MatusGuy added category:code status:needs-review Work needs to be reviewed by other people type:bugfix Pull Requests that fix bugs. labels Apr 4, 2024
@MatusGuy
Copy link
Member Author

MatusGuy commented Apr 4, 2024

i'm figuring a few things out. when im done i will reopen this

@MatusGuy MatusGuy closed this Apr 4, 2024
@MatusGuy
Copy link
Member Author

MatusGuy commented Apr 4, 2024

the fix is now present in #2812

@Brockengespenst
Copy link
Contributor

I think it would be good to apply these changes, as it should at least solve several issues with slopes. Additional fixes may be done in subsequent PRs.

Copy link
Member

@Vankata453 Vankata453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function would generally have to be improved to take tile types bitwise. But this fixes the swimming issue.

@MatusGuy MatusGuy merged commit 9a9a84e into SuperTux:master Apr 25, 2024
64 of 66 checks passed
@mrkubax10 mrkubax10 removed the status:needs-review Work needs to be reviewed by other people label Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:code type:bugfix Pull Requests that fix bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants