Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better "transportation" sprites for worldmaps #1764

Merged
merged 12 commits into from
Jun 17, 2023
Merged

Better "transportation" sprites for worldmaps #1764

merged 12 commits into from
Jun 17, 2023

Conversation

Rusty-Box
Copy link
Member

@Rusty-Box Rusty-Box commented Jun 15, 2021

With the help of @Alzter, this PR adds improved boat sprites as well as a new transportation methode aside the boat, granito.

There are still a few things that I need help fixing as I have no idea how to solve/what causes them:

  • Boat doesn't show proper empty sprite when not in use, however granito does
  • Changing power-up via cheat menu doesn't change sprite immediately, only upon changing directions

@weluvgoatz
Copy link
Member

The first point of issue in this PR can probably be fixed with some code adjustments, as the game might not recognize some of the sprite actions you specified in boat.sprite as actions that the game needs to make happen.

@weluvgoatz weluvgoatz added the status:in-progress Progress has been done, but more is intended be done label Jul 11, 2021
@Rusty-Box Rusty-Box added this to the 0.7.0 milestone Aug 2, 2021
@Guih48
Copy link

Guih48 commented Nov 5, 2021

I think that also would be good, if small and big tux could have different sprite (ok, where is the sprite???)

@Rusty-Box
Copy link
Member Author

Rusty-Box commented Nov 6, 2021

@Guih48 What do you mean “where is the sprite”? There are separate sprites for small and big Tux in both boat and granito mode

@Guih48
Copy link

Guih48 commented Nov 6, 2021

@Guih48 What do you mean “where is the sprite”? There are separate sprites for small and big Tux in both boat and granito mode

Yes, but they aren't look different (and if we would make they different we need a new sprite)

@Rusty-Box
Copy link
Member Author

@Guih48 What do you mean “where is the sprite”? There are separate sprites for small and big Tux in both boat and granito mode

Yes, but they aren't look different (and if we would make they different we need a new sprite)

Uh… yes they are different… one is taller than the other

@Guih48
Copy link

Guih48 commented Nov 6, 2021

@Guih48 What do you mean “where is the sprite”? There are separate sprites for small and big Tux in both boat and granito mode

Yes, but they aren't look different (and if we would make they different we need a new sprite)

Uh… yes they are different… one is taller than the other

Oh sorry, i don't noticed the difference :(
(Because we need to make sprites more different?)

@Semphriss
Copy link
Member

@Rusty-Box Can this be rebased on latest master?

@Rusty-Box
Copy link
Member Author

Okay, I went back to this and currently it seems the only bug still present is that the sprite can't quite update when moving up and/or down.

An example:
As Big Tux I go onto a boat/granito and move on an up or down path. Now I wanna change my powerup state with the cheat menu to Fire Tux, while I'm on said path. However, instead of showing Fire Tux now in the boat/granito, I still see Big Tux in it until my boat/granito either begins to move to the right or the left. Only then it seems to update the sprite it is supposed to show.

@Rusty-Box Rusty-Box removed the status:in-progress Progress has been done, but more is intended be done label Jun 17, 2023
@Rusty-Box Rusty-Box merged commit d7b9f45 into SuperTux:master Jun 17, 2023
@mrkubax10 mrkubax10 removed the status:needs-review Work needs to be reviewed by other people label Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants