New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix event listener registration (bind this) and removal in web-hid-wrapper.ts #103

Merged

nytamin merged 1 commit into SuperFlyTV:master from loucadufault:master

Aug 12, 2024

Contributor

loucadufault commented Jul 29, 2024 •

edited

Loading

Not sure how/if this was working previously. Issues fixed:

registered event listeners should be bound to this
removed event listeners should be the same function references as were registered
remove 'error' event listener on close to avoid memory leak


          Fix event listener registration (bind this) and removal in web-hid-wr…

0d44da7

…apper.ts

nytamin self-requested a review

July 29, 2024 16:40

nytamin merged commit 0d44da7 into SuperFlyTV:master

6 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet