ED-2252: Add OCI oss support in Build/DataPipeline/EdDataProducts #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Deepak Devadathan <[email protected]>
Signed-off-by: Deepak Devadathan <[email protected]>
Signed-off-by: Deepak Devadathan <[email protected]>
Signed-off-by: Deepak Devadathan <[email protected]>
Signed-off-by: Deepak Devadathan <[email protected]>
Signed-off-by: Deepak Devadathan <[email protected]>
Signed-off-by: Deepak Devadathan <[email protected]>
Signed-off-by: Deepak Devadathan <[email protected]>
Signed-off-by: Deepak Devadathan <[email protected]>
Signed-off-by: Deepak Devadathan <[email protected]>
Signed-off-by: Deepak Devadathan <[email protected]>
Signed-off-by: Deepak Devadathan <[email protected]>
Signed-off-by: Deepak Devadathan <[email protected]>
Signed-off-by: Deepak Devadathan <[email protected]>
Signed-off-by: Deepak Devadathan <[email protected]>
Signed-off-by: Deepak Devadathan <[email protected]>
Signed-off-by: Deepak Devadathan <[email protected]>
Signed-off-by: Deepak Devadathan <[email protected]>
Signed-off-by: Deepak Devadathan <[email protected]>
Signed-off-by: Deepak Devadathan <[email protected]>
Signed-off-by: Deepak Devadathan <[email protected]>
update config without hardcode reports container
convert the param to string
add logging info
use globalContainer for report
change to bucket specific
and cleaning up the code
DU-550: changes for funnel reports
kumarks1122
reviewed
Aug 3, 2023
Comment on lines
58
to
60
| case "oci" => | ||
| spark.sparkContext.hadoopConfiguration.set("fs.s3n.awsAccessKeyId", AppConf.getConfig(storageKey)); | ||
| spark.sparkContext.hadoopConfiguration.set("fs.s3n.awsSecretAccessKey", AppConf.getConfig(storageSecret)); |
There was a problem hiding this comment.
@ddevadat Statements seem to be identical. So multiple conditions can be passed as below.
case "s3" | "oci" =>
Comment on lines
185
to
186
| case "oci" => | ||
| CommonUtil.getS3File(storageConfig.container, ""); |
There was a problem hiding this comment.
@ddevadat Since statements are same, multiple conditions can be passed as below.
case "s3" | "oci" =>
data-products/src/main/scala/org/sunbird/analytics/exhaust/OnDemandExhaustJob.scala
Outdated
Show resolved
Hide resolved
data-products/src/main/scala/org/sunbird/analytics/exhaust/OnDemandExhaustJob.scala
Outdated
Show resolved
Hide resolved
kumarks1122
reviewed
Aug 3, 2023
Signed-off-by: Deepak Devadathan <[email protected]>
Signed-off-by: Deepak Devadathan <[email protected]>
Signed-off-by: Deepak Devadathan <[email protected]>
Signed-off-by: Deepak Devadathan <[email protected]>
Signed-off-by: Deepak Devadathan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add OCI oss support in Build/DataPipeline/EdDataProducts