Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: proposal for exposing Sidecar configuration #467

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sumo-drosiek
Copy link
Contributor

@sumo-drosiek sumo-drosiek commented Feb 13, 2023

I would like to start discussion, and feel this seems good way as it is easy to comment specific parts of document as well as full document itself. I wanted to avoid working in external doc

Signed-off-by: Dominik Rosiek <[email protected]>
@sumo-drosiek sumo-drosiek requested a review from a team as a code owner February 13, 2023 12:35
@sumo-drosiek sumo-drosiek changed the title chore: proposal for issue#30 chore: proposal for exposing Sidecar configuration Feb 13, 2023

### Extending TalingSidecarConfig Custom Resource Definition

I believe it should be possible to specify conifiguration per TailingSidecarConfig, but I would leave it for future.
Copy link
Contributor

@kasia-kujawa kasia-kujawa Mar 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example TailingSidecarConfig with options to configure sidecar, example structure with sidecar key added:

apiVersion: tailing-sidecar.sumologic.com/v1
kind: TailingSidecarConfig
metadata:
  name: tailingsidecar-sample
spec:
  sidecar:
    config:
      # configuration which will be added to ConfigMap created by TailingSidecar Operator
    container:
      image: {}
      command: ""
      resources: {}
      # the rest of configuration options for Container Spec https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.22/#container-v1-core     
  annotationsPrefix: tailing-sidecar.sumologic.com
  podSelector:
    matchLabels:
      tailing-sidecar: "true"
  configs:
    sidecar-0:
      volumeMount:
        name: varlog
        mountPath: /var/log
      path: /var/log/example0.log
      annotations:
        sourceCategory: sourceCategory-0
        annotation-0: "true"
    sidecar-1:
      volumeMount:
        name: varlog
        mountPath: /var/log
      path: /var/log/example1.log
      annotations:
        sourceCategory: sourceCategory-1
        annotation-1: "true"
    sidecar-2:
      volumeMount:
        name: varlogconfig
        mountPath: /varconfig-new-dir/log
        readOnly: true
        mountPropagation: HostToContainer
      path: /varconfig-new-dir/log/example2.log
      annotations:
        sourceCategory: sourceCategory-2
        annotation-2: "true"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants