Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timezone setting for alerts/monitors #3291

Merged
merged 4 commits into from
Nov 7, 2023
Merged

Timezone setting for alerts/monitors #3291

merged 4 commits into from
Nov 7, 2023

Conversation

kimsauce
Copy link
Collaborator

@kimsauce kimsauce commented Nov 6, 2023 •
edited
Loading

Purpose of this pull request

This pull request adds new timezone setting for alerts/monitors

Select the type of change:

  • Minor Changes - Typos, formatting, slight revisions, .clabot
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - Updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Nov 6, 2023
@kimsauce kimsauce self-assigned this Nov 6, 2023
jpipkin1
jpipkin1 approved these changes Nov 6, 2023
View reviewed changes
Copy link
Collaborator

@jpipkin1 jpipkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @kimsauce. I suggest you add a border to the image.

@kimsauce kimsauce added the do-not-merge Pull requests that should not be merged label Nov 6, 2023
@kimsauce @jpipkin1
Update docs/alerts/monitors/create-monitor.md
0552e8c 
Co-authored-by: John Pipkin (Sumo Logic) <[email protected]>
@ndhar-sumo
Copy link

@kimsauce Is there any place in document where we mention about Alert Response Page? It would be good to have below mentioned there - ARP page will continue to show alert details in user preferences timezone.

@kimsauce
Copy link
Collaborator Author

kimsauce commented Nov 7, 2023

@kimsauce Is there any place in document where we mention about Alert Response Page? It would be good to have below mentioned there - ARP page will continue to show alert details in user preferences timezone.

@ndhar-sumo Sure thing - let me know what you think.

@kimsauce kimsauce mentioned this pull request Nov 7, 2023
Open
@kimsauce kimsauce added this pull request to the merge queue Nov 7, 2023
Merged via the queue into main with commit 361dc21 Nov 7, 2023
3 checks passed
@kimsauce kimsauce deleted the alert-timezone branch November 7, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpipkin1 jpipkin1 jpipkin1 approved these changes

@stacykor stacykor Awaiting requested review from stacykor

@JV0812 JV0812 Awaiting requested review from JV0812 JV0812 is a code owner

@dstephens5 dstephens5 Awaiting requested review from dstephens5

@ndhar-sumo ndhar-sumo Awaiting requested review from ndhar-sumo

Assignees

@kimsauce kimsauce

Labels
cla-signed Contributor approved, listed in .clabot file do-not-merge Pull requests that should not be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kimsauce @ndhar-sumo @dstephens5 @jpipkin1