Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.16.2+ update #5

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

TTothh
Copy link

@TTothh TTothh commented Oct 23, 2020

Updated the format to 6

Updated the format to 6
@lipki
Copy link
Contributor

lipki commented Oct 24, 2020

Thanks, I'm watching this weekend.
Do not hesitate to make issue before a PR

@lipki
Copy link
Contributor

lipki commented Oct 24, 2020

OK then.
Why did you delete folders?
colormap
lightmap
etc ...

@TTothh
Copy link
Author

TTothh commented Oct 25, 2020

Oh hell. My bad. I left them out. Will fix

@TTothh
Copy link
Author

TTothh commented Oct 25, 2020

Should be fixed and up to date now.
Tho I left in the vine connected texture because i'm not a pixel artist.
Also if you prefer issue tickets over pull request let me know.

@lipki
Copy link
Contributor

lipki commented Oct 26, 2020

Yes. A issue first, and then the PR.
It is easier for me to know the purpose of the PR.
And then, it avoids working in pairs on the same subject.

@lipki
Copy link
Contributor

lipki commented Oct 26, 2020

Especially for a PR of 1393 files :D

@lipki
Copy link
Contributor

lipki commented Oct 26, 2020

I will not merge this PR.
I was working on updating this pack myself.
And I applied your changes (in part) directly.
You are cited in the credits.

For the vine I am in the process of remaking a version, I will make an issue soon.

Thanks for your contribution.
I'm waiting for the next one: D

@TTothh
Copy link
Author

TTothh commented Oct 26, 2020

Noted.
I just needed the the CTM's and kind of started working on updating the whole thing.
I like the pack much but I don't know where could I help or if you need another contributor.

@lipki
Copy link
Contributor

lipki commented Oct 26, 2020

At the moment I am working with a "Nazara" server (mmorpg).
I make them a version of the pack with all the options.
Optifine, ctm, random mob, custom mob, random texture, etc ...

I need help, I am on my own.
https://github.com/SummerFields/ProjetN/issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants