-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Asyncio in run tests script #179
base: master
Are you sure you want to change the base?
Conversation
Only tested for Linux and tested locally. This branch should evolve more.
The py versions are too old in the docker images :) |
Thank you for working on it. I wanted to rewrite the script for a long time. We use a different file |
How attached are you to the run_tests.ps1 script? Would it be possible to run run_tests.py in a windows environment as well? Because we're running a TCP server in run_tests.py and I don't know how to achieve that in Powershell. Other than calling the run_tests.py script from run_tests.ps1. |
Actually, the windows support was mainly contributed by @guillermooo. I personally do not have any preference. Actually, it may be easier for a maintenance point of view if any platform uses the same code. It may be a good time to introduce some breakage when ST4 is out. |
7690bbf
to
fbf0a56
Compare
Only tested for Linux and tested locally. So my expectation is that the CI will fail.
This branch should evolve more.
I have also replaced the polling behavior to check whether the UnitTesting plugin is loaded by a UnitTestingSchedulerPingCommand class. The run_tests.py script calls this command via
subl --command unit_testing_scheduler_ping
. Once UnitTesting is loaded, that command will write to a flie. In run_tests.py we check whether that file exists. If it exists, then we know that UnitTesting is loaded.