Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Subito customizations to version 9.12.0 #7

Merged
merged 8 commits into from
Apr 18, 2024

Conversation

dmazzoni
Copy link

@dmazzoni dmazzoni commented Apr 17, 2024

Summary of changes

This PR applies the Subito-specific customizations introduced by #6 to version 9.12.0 of the Drop-In SDK.

The only customization that sees an additional change introduced by this PR is the replacement inside the card form of the bar button item with a confirm button displayed at the bottom of the form itself. Given that version 9.9.0 of the Drop-In SDK introduced a privacy label at the bottom of the form, commit 43e7255 adds a spacing after our add card button to avoid having them displayed too close together.


Preview (card form)

Without custom spacing With custom spacing

@dmazzoni dmazzoni force-pushed the subito/9.12.0-customizations branch from 712ff30 to 445609c Compare April 17, 2024 12:49
@dmazzoni dmazzoni requested a review from Faber92 April 17, 2024 12:59
@dmazzoni dmazzoni merged commit c9a6b76 into subito/9.12.0 Apr 18, 2024
2 of 4 checks passed
@dmazzoni dmazzoni deleted the subito/9.12.0-customizations branch April 18, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants