Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make code examples interactive #6

Merged
merged 3 commits into from
Sep 22, 2024
Merged

make code examples interactive #6

merged 3 commits into from
Sep 22, 2024

Conversation

srenatus
Copy link
Member

This changes the markdown generation so that it injects the tags that our website uses.

I'm a bit on the fence -- it makes the markdown less useful to other people, but it would be so nice to have interactive examples on the website 🤔

Signed-off-by: Stephan Renatus <[email protected]>
Signed-off-by: Stephan Renatus <[email protected]>
Copy link
Member

@anderseknert anderseknert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way we present the cheat sheet in its repo, I think it's made clear that our docs should be considered the canonical source. Making those interactive is a big win!

@srenatus srenatus merged commit 51e99f8 into main Sep 22, 2024
1 check passed
@srenatus srenatus deleted the sr/interactive branch September 22, 2024 06:36
@srenatus
Copy link
Member Author

Hmm something unexpected happened. It's not working right now. I'll sort it out first thing tomorrow, but we could also revert this.

@srenatus
Copy link
Member Author

srenatus commented Sep 22, 2024

Looks like the hidden preamble is eaten by docusaurus in prod build mode? Everything was nice for dev 🙄

So one fix would be to present the preamble instead.

@srenatus srenatus mentioned this pull request Sep 22, 2024
@anderseknert
Copy link
Member

Ah, too bad! Yeah, let’s come back tomorrow:)

@srenatus
Copy link
Member Author

Ok that didn't do it. 😵 Tomorrow it is then.

@srenatus
Copy link
Member Author

🤦 I had the depends logic in a WIP PR. well, easy to fix.

@srenatus
Copy link
Member Author

Done 🥳 Should go live in a few minutes.

@srenatus
Copy link
Member Author

image

✔️

There are a bunch of errors in the console, though. that's not right 🧐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants