Background transparent fix #92
Conversation
- Moved setBackground to mpv-version - This ensures it only triggers once on start of player. It seems like duration also triggers onEnd of player.
- Check if webview or qt to prevent setting opengl-cb for webview app
|
@Zaarrg this PR will probably need to be split into multiple PRs as it handles more things than just the background fix, you're doing some amazing work and we congratulate you for that, i would suggest that you send me an email (my email is publicly available on my github page) to discuss if you want to work on the official Stremio shells, and also discuss the use of our trademarked brand in your unofficial shell because while we allow the use of our brand by some community projects, we only do so based on acceptance of the use case and the way it is presented, your project breaks quite a few of our internal rules regarding allowing the use of the brand, i'm sure we can figure it out but we'd need to discuss it properly |
|
@Zaarrg ping |
|
Ah thank you for pinging, did not notice. Emailed you. Regarding the pr, it can be closed and split, thank you for the feedback. |
|
@Zaarrg are you sure that you wrote the right email? I didn't receive anything yet and even tested by sending myself an email (and that worked) 😄 |
|
@Zaarrg i was wrong, i did receive it, i will reply asap |
|
@jaruba Glad it came through! Just confirming I used [email protected] as listed on your GitHub. No rush at all—take your time! |
|
@Zaarrg Ivo will answer and CC me, he found ur response too now, he is the original developer of Stremio and the best person to talk to about both the shell and assessing the possibility of joining the official team |
- Fixed setBackground running after unload - setBackground(false); has to happen in duration otherwise blackscreen issue see [here](Zaarrg/stremio-desktop-v5#12). - Hopefully this does not cause the blackscreen issue again but it shouldnt.
- Sets gpu-next directly and correct input props
- Support for subtitle delay for embedded subtitles in shell player
|
@Zaarrg the changes from this PR have been split into 3 separate PRs:
These changes were not accepted though:
For the last 2 it's because we cannot add logic specific to other shells into the official shell. We also ask you to remove the "HDR Comparison" from the README of your project as that is no longer true. |
|
@jaruba This pr was a scrap anyways. As i forgot to create branches for each pr i wanted to make. Meaning all changes specific to the my shell got also pushed into this pr even though the only fixes relevant for the pr are the ones you merged. Also removed the HDR Comparison from the readme. |
Before -
"duration"is triggered after player unmount still setting background as transparent:After - Sets background visible false on
"mpv-version"which is always triggered only once on start of playback:(Playback ended after error)