Skip to content

Feat/fallible TryFromProtobuf trait #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Feat/fallible TryFromProtobuf trait #81

wants to merge 3 commits into from

Conversation

elpiel
Copy link
Member

@elpiel elpiel commented Mar 27, 2025 •
edited
Loading

  • Action & Runtime action
  • Added -kotlin fallible ABI function
  • AddToLibrary will now return an error if e.g. MetaItemPreview urls (like logo or background) are invalid Urls

elpiel added 3 commits March 27, 2025 12:59
@elpiel
feat(protobuf): bridge - fallible trait TryFromProtobuf
2799fd4 
- feat(protobuf): bridge - impl fallible trait for String to Url
- feat(protobuf): bridge - fallible MetItemPreview

Signed-off-by: Lachezar Lechev <[email protected]>
@elpiel
feat: runtime::Action & runtime::RuntimeAction fallible TryFromProtob…
303b89f 
…uf trait impl

Signed-off-by: Lachezar Lechev <[email protected]>
@elpiel
feat(kotlin): fallible ABI function dispatchNativeResult
1e1c829 
Signed-off-by: Lachezar Lechev <[email protected]>
@elpiel
Copy link
Member Author

elpiel commented Mar 28, 2025

This might not be needed at the end.
Data is sent from core to protobuf and then back to core. If no mutations have been performed on the data, no panics should occur.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@elpiel