Skip to content
This repository was archived by the owner on Nov 25, 2019. It is now read-only.

fixes polls exposing player realname #51

Closed
wants to merge 1 commit into from
Closed

fixes polls exposing player realname #51

wants to merge 1 commit into from

Conversation

PotatoStealer
Copy link

No description provided.

@Electroid
Copy link

Problem is if the person is nicked, the message doesn't show up at all. You need to find the player's User document then send a PlayerComponent. This might be too complicated, in which case, just leave that bug be.

@PotatoStealer
Copy link
Author

I think rewriting the polls package and changing it to use Components instead of hardcoded Strings sound like a better approach?

@Electroid
Copy link

Don't touch too much of polls (the code is ancient and will likely be re-written one day), just change the getInitiator object to return a @Nullable PlayerId and then you can use that to create a PlayerComponent.

@PotatoStealer
Copy link
Author

I think I'll leave the PR here first, since it looks like an ugly fix to me at the point of writing - until the code is re-written.

@Electroid Electroid force-pushed the master branch 2 times, most recently from 6792953 to 9600ab6 Compare November 25, 2017 11:22
@amactus
Copy link
Member

amactus commented Dec 22, 2017

so @Electroid @PotatoStealer is it better to have the message not show when someone is nicked, or do the fix electroid proposed. This is still an issue, and waiting for a re-write makes little sense

@AustinLMayes
Copy link

Closed in favor of #67

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants