Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cache options for prevent underscore in URLs #54

Merged

Conversation

vmalyk
Copy link
Contributor

@vmalyk vmalyk commented Nov 26, 2019

Solves #34

@gsomoza
Copy link
Member

gsomoza commented Feb 10, 2020

Thanks for your PR! Could you please explain what you mean by "underscore in URLs"? If you're still interested in this change please feel free to update your fork with the latest changes to the module.

@vmalyk
Copy link
Contributor Author

vmalyk commented Feb 10, 2020

@gsomoza ,

Conflicts are resolved.
"underscore in URLs" - it's about parameter "_ " It's added by jQuery for AJAX requests for non-cached requests and handled by option for$.get, $.ajax - cache (by default , it's false) and It's described in discussion #34. For resolving I updated IAS library to 2.3.1 - It's provides to set up options on load event and set cache option to true.

@gsomoza
Copy link
Member

gsomoza commented Feb 10, 2020

Oh right, sorry I was reading this in my email and forgot to check the PR description. It's clear, thanks for the fix! I'll merge and release now.

@gsomoza gsomoza merged commit 57f3e52 into Strategery-Inc:master Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants