Skip to content

Commit

Permalink
Remove version from composer.json
Browse files Browse the repository at this point in the history
  • Loading branch information
@ihor-sviziev
ihor-sviziev authored Jul 15, 2019
1 parent 83b66c8 commit 3fdfba2
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion composer.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
"name": "strategery/magento2-infinitescroll",
"description": "Magento2 InfiniteScroll module to load the next catalog page or results when scrolling down a page.",
"type": "magento2-module",
"version": "0.2.5",
"license": [
"OSL-3.0",
"AFL-3.0"
Expand Down

3 comments on commit 3fdfba2

@TuVanDev
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ihor-sviziev can I ask you for that changes? why the version should remove from composer.json?
Looks like the version in composer.json indicates which version is it.
If the version removes from composer.json so everyone doesn't know which version they installed and we can't get module updates automatically?

@ihor-sviziev
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Viper9x,
The version inside composer.json overrides the version you actually trying to install. If it’s not defined - packagist using git branches and tags to check which version you would like to install.
So basically it’s not needed for composer

@TuVanDev
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ihor-sviziev thanks for your information.

Please sign in to comment.