Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix French translation. #2981

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

miniupnp
Copy link
Contributor

redact (black out) => Caviarder/Caviardage

thanks @ralmn

Description of Changes

Please provide a summary of the changes, including:

  • What was changed
  • Why the change was made
  • Any challenges encountered

Closes #(issue_number)


Checklist

General

Documentation

UI Changes (if applicable)

  • Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR)

Testing (if applicable)

  • I have tested my changes locally. Refer to the Testing Guide for more details.

Copy link
Contributor

github-actions bot commented Feb 17, 2025

🚀 Translation Verification Summary

🔄 Reference Branch: main-branch-messages_en_GB.properties

📃 File Check: messages_fr_FR.properties

  1. Test Status:Passed
  2. Test Status:Passed
  3. Test Status:Passed

✅ Overall Check Status: Success

Thanks @miniupnp for your help in keeping the translations up to date.

@Ludy87
Copy link
Contributor

Ludy87 commented Feb 18, 2025

@miniupnp Please check your translation, there is a conflict in the translation

@miniupnp
Copy link
Contributor Author

miniupnp commented Feb 18, 2025

@miniupnp Please check your translation, there is a conflict in the translation

4b40a04 has introduced a new translation for "redact (black out)" which is "censurer".

I don't agree with the author. "Censurer" is an imprecise word.
"Caviarder"(verb) / "caviardage" (noun) is very precise :
As stated by the Académie Française it precisely means "black out some part of a text with black ink to censor it"

@Ludy87 How such dispute in the translation could be settled ?

@bendem
Copy link
Contributor

bendem commented Feb 18, 2025

Sure "caviarder" is the more precise term, I was going for the more widely recognised term instead. I personnally don't think most people who want to redact their pdf know what "caviarder" mean but understand the concept of "censure", also, the french academia is a joke.

Apart from that, I don't really care as long as it's consistent, and "rédiger" is clearly wrong.

@miniupnp
Copy link
Contributor Author

Sure "caviarder" is the more precise term, I was going for the more widely recognised term instead. I personnally don't think most people who want to redact their pdf know what "caviarder" mean but understand the concept of "censure", also, the french academia is a joke.

The "Office Québecois de la Langue Française" also lists "caviarder" :
https://vitrinelinguistique.oqlf.gouv.qc.ca/fiche-gdt/fiche/8417671/caviarder

Apart from that, I don't really care as long as it's consistent, and "rédiger" is clearly wrong.

"caviarder" is widely used in french press :

This verb is present in all major french language dictionaries :

@miniupnp
Copy link
Contributor Author

I'm going to rebase to fix the conflict anyway

@bendem
Copy link
Contributor

bendem commented Feb 19, 2025

I already agreed with you that "caviarder" is the technically correct term. There is no need to pile up arguments (and arguments about Québecois belong in fr_CA, not fr_FR).

All I'm saying is that being understood matters more than being technically correct. Granted it's not a significant population (maybe 10 people, all in IT or adjacent), no one to whom I presented stirling, knew what caviarder meant.

Let's go ahead and merge your PR once it's rebased, there is no point in arguing about this. It's easy to prove you are technically correct, it's impossible to prove that the term caviarder is not useful for the majority of the tool user.

redact (black out) => Caviarder/Caviardage

thanks @ralmn
@ralmn ralmn force-pushed the fr-translation-bis branch from fd9d76e to 6ec8aea Compare February 19, 2025 15:19
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Feb 19, 2025
@miniupnp
Copy link
Contributor Author

@bendem I'm a bit surprised to hear that nobody whom you presented Stirling-PDF knew what "caviarder" meant.
As stated above, this word is widely used in the French press... I asked a few people who don't work in IT and they know what it means.

Maybe if that word is not used much in Belgium, we could create add a fr_BE translation ? 😉
As there is currently no othere fr_* translation than fr_FR, I checked that this word is known by french speakers outside France : Canadian french is maybe the most different French language "version" compared to the French language spoken in France, so if they use Caviarder, it is safe to assume that it is a word known outside of France.

Anyway, this translation has been introduced in commit 0cb5a6c by @deraw more than 1 year ago and has not caused any issue as far as I know.
I made a mistake in translating "manual redact" a few weeks ago, and a colleague made me correct it.

Regards,

Thomas

@ralmn
Copy link
Contributor

ralmn commented Feb 19, 2025

@miniupnp Please check your translation, there is a conflict in the translation

@Ludy87 : We did the rebase with @miniupnp

Ludy87
Ludy87 previously approved these changes Feb 19, 2025
@Ludy87 Ludy87 self-requested a review February 19, 2025 22:02
@benji78
Copy link

benji78 commented Feb 20, 2025

I randomly stumbled on this issue and was very surprised to see caviar (as in sturgeon eggs) 😆 in a PDF tool.
For the context, I live in the Paris region and have asked my enlarged family and friends living in all parts of France if they knew the meaning of this verb. Only a few did even with the following context Caviardage manuel/automatique des informations sensibles. The few (less than 10%) who knew that verb have had to redact some confidential information as part of their job before. I have to do it too but only ever called it and heard about censurer.
I don't think "caviarder" is known enough by the general population to be used here.

I suggest looking at what Adobe uses: https://www.adobe.com/fr/learn/acrobat/web/redact-pdf
They chose biffer and Suppression d’informations confidentielles which, in my opinion are better than censurer and even more so than caviarder.

Other suggestions: noircir, masquer, occulter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files. Translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants