llvm: add static_cast to MDMap return #310
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucky-rydar
reviewed
Nov 9, 2020
|
To be honest - I don't speak much C++. If doing what you said is more idiomatic, that's fine so long as it builds. :-) The problem came when building with GNU C++ 8.3 (Debian 'buster'). (That's assuming someone's going to merge the pull request; the repo seems fairly dead at this point, sadly.) |
lucky-rydar
approved these changes
Nov 9, 2020
|
I thank you all, my compilation problem was solved today, thanks to this change. |
marceloalencar
added a commit
to marceloalencar/minix
that referenced
this pull request
Mar 30, 2021
This fixes compilation according to Stichting-MINIX-Research-Foundation#301 and Stichting-MINIX-Research-Foundation#310.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a build error on later compilers.