-
-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ci: Fix existing release check by adding an environment variable for …
…the tag name Also fixed the GitHub releases publish step not using the correct tag name.
- Loading branch information
1 parent
e0a59d4
commit d1faeb9
Showing
5 changed files
with
35 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,17 +33,20 @@ jobs: | |
| - name: Print version string | ||
| run: echo version string ${{ steps.mod_version.outputs.value }}+mc${{ steps.supported_minecraft_version_name.outputs.value }} | ||
|
|
||
| - name: Set release tag name environment variable | ||
| run: echo release_tag_name=v${{ steps.mod_version.outputs.value }}+mc${{ steps.supported_minecraft_version_name.outputs.value }} >> $GITHUB_ENV | ||
|
|
||
| - name: Get existing release | ||
| uses: cardinalby/git-get-release-action@v1 | ||
| id: get_existing_release | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| with: | ||
| tag: v${{ steps.mod_version.outputs.value }}+mc${{ steps.supported_minecraft_version_name.outputs.value }} | ||
| tag: ${{ env.release_tag_name }} | ||
| doNotFailIfNotFound: true | ||
|
|
||
| - name: Check if an existing release with the same version exists | ||
| if: steps.get_existing_release.outputs.tag_name == 'v'steps.mod_version.outputs.value'+mc'steps.supported_minecraft_version_name.outputs.value | ||
| if: steps.get_existing_release.outputs.tag_name == env.release_tag_name | ||
| run: exit 1 | ||
|
|
||
| - name: Setup JDK (Temurin 17) | ||
|
|
@@ -68,5 +71,6 @@ jobs: | |
| - name: Publish mod to GitHub releases | ||
| uses: ncipollo/[email protected] | ||
| with: | ||
| tag: ${{ env.release_tag_name }} | ||
| artifacts: "**/build/libs/!(*-@(dev-shadow|transformProduction*).jar)" | ||
| bodyFile: CHANGELOG_LATEST.md | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,17 +33,20 @@ jobs: | |
| - name: Print version string | ||
| run: echo version string ${{ steps.mod_version.outputs.value }}+mc${{ steps.supported_minecraft_version_name.outputs.value }} | ||
|
|
||
| - name: Set release tag name environment variable | ||
| run: echo release_tag_name=v${{ steps.mod_version.outputs.value }}+mc${{ steps.supported_minecraft_version_name.outputs.value }} >> $GITHUB_ENV | ||
|
|
||
| - name: Get existing release | ||
| uses: cardinalby/git-get-release-action@v1 | ||
| id: get_existing_release | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| with: | ||
| tag: v${{ steps.mod_version.outputs.value }}+mc${{ steps.supported_minecraft_version_name.outputs.value }} | ||
| tag: ${{ env.release_tag_name }} | ||
| doNotFailIfNotFound: true | ||
|
|
||
| - name: Check if an existing release with the same version exists | ||
| if: steps.get_existing_release.outputs.tag_name == 'v'steps.mod_version.outputs.value'+mc'steps.supported_minecraft_version_name.outputs.value | ||
| if: steps.get_existing_release.outputs.tag_name == env.release_tag_name | ||
| run: exit 1 | ||
|
|
||
| - name: Setup JDK (Temurin 17) | ||
|
|
@@ -76,7 +79,7 @@ jobs: | |
| curseforge-token: ${{ secrets.CURSEFORGE_TOKEN }} | ||
|
|
||
| name: ${{ steps.mod_version.outputs.value }} (${{ steps.supported_minecraft_version_name.outputs.value }}) | ||
| github-tag: v${{ steps.mod_version.outputs.value }}+mc${{ steps.supported_minecraft_version_name.outputs.value }} | ||
| github-tag: ${{ env.release_tag_name }} | ||
| files: | | ||
| fabric/build/libs/!(*-@(sources|dev-shadow|javadoc|transformProduction*).jar) | ||
| fabric/build/libs/*-@(sources|javadoc).jar | ||
|
|
@@ -95,7 +98,7 @@ jobs: | |
| curseforge-token: ${{ secrets.CURSEFORGE_TOKEN }} | ||
|
|
||
| name: ${{ steps.mod_version.outputs.value }} (${{ steps.supported_minecraft_version_name.outputs.value }}) | ||
| github-tag: v${{ steps.mod_version.outputs.value }}+mc${{ steps.supported_minecraft_version_name.outputs.value }} | ||
| github-tag: ${{ env.release_tag_name }} | ||
| files: | | ||
| forge/build/libs/!(*-@(sources|dev-shadow|javadoc|transformProduction*).jar) | ||
| forge/build/libs/*-@(sources|javadoc).jar | ||
|
|
@@ -114,7 +117,7 @@ jobs: | |
| curseforge-token: ${{ secrets.CURSEFORGE_TOKEN }} | ||
|
|
||
| name: ${{ steps.mod_version.outputs.value }} (${{ steps.supported_minecraft_version_name.outputs.value }}) | ||
| github-tag: v${{ steps.mod_version.outputs.value }}+mc${{ steps.supported_minecraft_version_name.outputs.value }} | ||
| github-tag: ${{ env.release_tag_name }} | ||
| files: | | ||
| neoforge/build/libs/!(*-@(sources|dev-shadow|javadoc|transformProduction*).jar) | ||
| neoforge/build/libs/*-@(sources|javadoc).jar | ||
|
|
@@ -125,6 +128,7 @@ jobs: | |
| - name: Publish mod to GitHub releases | ||
| uses: ncipollo/[email protected] | ||
| with: | ||
| tag: ${{ env.release_tag_name }} | ||
| artifacts: "**/build/libs/!(*-@(dev-shadow|transformProduction*).jar)" | ||
| bodyFile: CHANGELOG_LATEST.md | ||
|
|
||
|
|
||