Merge pull request #578 from SteveDunn/575-fix-for-when-project-conta…

…ins-a-generic-attribute-of-array-type

Fix for when project contains a generic attribute of array type

src/Vogen/SemanticHelper.cs

@@ -14,9 +14,10 @@ static class SemanticHelper
 
         var prefix = FullNamespace(symbol);
         var suffix = "";
+
         if (symbol.Arity > 0)
         {
-            suffix = $"<{string.Join(", ", symbol.TypeArguments.Select(targ => FullName((INamedTypeSymbol) targ)))}>";
+            suffix = $"<{string.Join(", ", symbol.TypeArguments.Select(a => FullName(a as INamedTypeSymbol)))}>";
         }
 
         if (prefix != "")

tests/ConsumerTests/BugFixTests/Tests.cs

@@ -0,0 +1,20 @@
+namespace ConsumerTests.BugFixTests;
+
+// There are no particular tests for this. The fact that it compiles without an issue
+public class Test<T> : Attribute { }
+
+[Test<byte[]>]
+public class Foo { }
+
+[ValueObject]
+public partial struct Vo { }
+
+public class Bar
+{
+    public Bar()
+    {
+        Vo.From(123);
+    }
+}
+
+

tests/SnapshotTests/BugFixes/Bug575_AttributesWithArraysBreaksGenerator.cs

@@ -0,0 +1,48 @@
+using System.Threading.Tasks;
+using Shared;
+using VerifyXunit;
+using Vogen;
+
+namespace SnapshotTests.BugFixes;
+
+// See https://github.com/SteveDunn/Vogen/issues/575
+[UsesVerify]
+public class Bug575_AttributesWithArraysBreaksGenerator
+{
+    // Previously, any attribute found with an array as a parameter caused an
+    // InvalidCastException in Vogen and stopped the generator.
+    [Fact]
+    public async Task Test()
+    {
+        var source = """
+
+                     using System;
+                     using Vogen;
+
+                     public class Test<T> : Attribute { }
+
+                     [Test<byte[]>]
+                     public class Test
+                     {
+                        Test() => Vo.From(123);
+                     }
+
+                     [ValueObject]
+                     public partial struct Vo
+                     {
+                     }
+
+
+                     """;
+
+        await RunTest(source);
+    }
+
+
+    private static Task RunTest(string source) =>
+        new SnapshotRunner<ValueObjectGenerator>()
+            .WithSource(source)
+            .IgnoreInitialCompilationErrors()
+            .RunOnAllFrameworks();
+
+}