Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use real native Chinese names in SC index.json #4196

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

10110111
Copy link
Contributor

This is a result of fetching all the constellation names from constellation_names.zh_CN.fab into index.json, yielding native names made of hieroglyphs and "pronounce" entries made of (diacriticless) pinyin.

10110111 referenced this pull request Mar 10, 2025
updated "pronounce" variable in the remaining half - needs to be filled with characters
@alex-w alex-w added the subsystem: skycultures The issue is related to skycultures of planetarium... label Mar 10, 2025
@alex-w alex-w added this to the 25.1 milestone Mar 10, 2025
@10110111 10110111 requested a review from sushoff March 10, 2025 05:17
@github-actions github-actions bot requested review from alex-w and gzotti March 10, 2025 05:27
@10110111
Copy link
Contributor Author

@sunshuwei You may want to review this too.

Copy link

Great PR! Please pay attention to the following items before merging:

Files matching skycultures/**:

  • Did you remember to update skycultures/CMakeLists.txt file respectively to changes in sky cultures?
  • Did you remember to define classification parameter in sky cultures (see index.json file)?
  • Did you remember to define license parameter in sky cultures (see description.md file)?
  • Did you remember to define region parameter in sky culture (see index.json file)?

This is an automatically generated QA checklist based on modified files.

@10110111 10110111 force-pushed the chinese-native-names branch from b1687a8 to 81c3d3d Compare March 10, 2025 07:32
@gzotti
Copy link
Member

gzotti commented Mar 10, 2025

Not being an expert on pinyin. Do we have diacritics in one, and non-diacritics in the other SC, or do we have unhealthy mixes now?

@10110111
Copy link
Contributor Author

Do we have diacritics in one, and non-diacritics in the other SC, or do we have unhealthy mixes now?

We have diacritics in some names of the same SC (DSO, stars) and no diacritics in others (constellations, planets). So I'd call it an unhealthy mix.

@sunshuwei
Copy link
Contributor

The diacritical mark is used to distinguish tones. In the Pinyin standard, as a transliterated vocabulary, it does not have diacritical marks, but as a strict phonetic notation, it has diacritical marks.
The constellation names were originally incorporated as native terms, hence their lack of diacritical marks.
In Chinese sky culture, the pinyin of star names was originally added as phonetic symbols, so there are diacritical marks.
Because at that time, constellations had native terms but no pronunciation terms, and stars did not have native terms.
Just didn't anticipate the current changes. If necessary, I can add all diacritical marks in the future.

@gzotti
Copy link
Member

gzotti commented Mar 10, 2025

This would be great. Yes, the project and data options have grown a lot. Ruslan and Fabien started using JSON with Stellarium-mobile years ago and added the "pronounce" key, while I had expected or preferred a "transliteration" key, while for "pronounce" I would have expected IPA annotation. There are other cases where both transliteration and pronounce and even IPA would be great. I know for Tibetan, scientists use Wylie which is not really a pronunciation help, and there is a pinyin for Tibetan as well. So, in the end we may fill tags "pronunciation" (for Chinese: "pinyin with diacritics"), transliteration (pinyin without), and "IPA" for international phonetic alphabet, if anyone can add that correctly. But these tags will not be used in 25.1 now. If you can later help filling the gaps, it would be welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
subsystem: skycultures The issue is related to skycultures of planetarium...
Development

Successfully merging this pull request may close these issues.

4 participants