-
-
Notifications
You must be signed in to change notification settings - Fork 865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use real native Chinese names in SC index.json #4196
base: master
Are you sure you want to change the base?
Conversation
updated "pronounce" variable in the remaining half - needs to be filled with characters
@sunshuwei You may want to review this too. |
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
b1687a8
to
81c3d3d
Compare
Not being an expert on pinyin. Do we have diacritics in one, and non-diacritics in the other SC, or do we have unhealthy mixes now? |
We have diacritics in some names of the same SC (DSO, stars) and no diacritics in others (constellations, planets). So I'd call it an unhealthy mix. |
The diacritical mark is used to distinguish tones. In the Pinyin standard, as a transliterated vocabulary, it does not have diacritical marks, but as a strict phonetic notation, it has diacritical marks. |
This would be great. Yes, the project and data options have grown a lot. Ruslan and Fabien started using JSON with Stellarium-mobile years ago and added the "pronounce" key, while I had expected or preferred a "transliteration" key, while for "pronounce" I would have expected IPA annotation. There are other cases where both transliteration and pronounce and even IPA would be great. I know for Tibetan, scientists use Wylie which is not really a pronunciation help, and there is a pinyin for Tibetan as well. So, in the end we may fill tags "pronunciation" (for Chinese: "pinyin with diacritics"), transliteration (pinyin without), and "IPA" for international phonetic alphabet, if anyone can add that correctly. But these tags will not be used in 25.1 now. If you can later help filling the gaps, it would be welcome. |
This is a result of fetching all the constellation names from
constellation_names.zh_CN.fab
intoindex.json
, yielding native names made of hieroglyphs and "pronounce" entries made of (diacriticless) pinyin.