-
-
Notifications
You must be signed in to change notification settings - Fork 865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace common star names with those in SSCs repo #4142
base: master
Are you sure you want to change the base?
Conversation
The So, the first and important question - where we're using |
I must admit I was not even aware of this file. What is the actual use? Currently all names seem to have come from Allen, which used to be a well-known standard before IAU cared for star names. Enlarging the list with entries from unknown sources is generally a bad idea IMO. (and I see that some references from the list are no longer available. Taking names from just any private or club homepages is indeed questionable. Books, DOI, other citable publications, yes.) Is it a fallback list for SCs that come without their own names and where names still should be displayed (is that the purpose of the "fallback_to_international_names" tag? There might be SCs without any proper names on purpose, then setting this to false is good. When set to true, does that mix international and own names, only for finding or for on-screen labeling? (More label options will be introduced as needed and useful...)) Maybe at this point the most useful list to place here is the now-common and official IAU star name list. In this case reference numbers will not be necessary, just a comment in the header ( |
IMHO we should use IAU-approved list of names as a data for Also I think SC should support at least 2 mode:
Maybe Bayer and Flamsteed designations shouldn't be used for strict mode |
First use that affects all SCs is for the Second is, indeed, the default names for SCs with
Currently, when this option is set, the common names are added after having added all culture-specific ones. |
OK, then let's use the IAU list here for clarity, no additions, no omissions. And please let's rename the file to iau_star_names.fab for added clarity. Good idea about strict/weak. Given the importance of Bayer/Flamsteed (BF) names, maybe they should be loaded in an intermediary setting, so that we can have original names but in addition BF labels, maybe even in the screen label. Should this manual selection override the "fallback_to_international_names"? Would it make that tag unnecessary? (I guess not. It just declares "this SC happily uses the international names as its own".) |
Nice! |
Note that some stars given there don't have a HIP identifier. Does Gaia have an identifier for all known stars? (BTW, why do I not get the XO-5 identifier in the info panel for XO-5?) |
Yes. @sushoff could you add Gaia DR3 designations for stars?
I got other designations through SIMBAD |
As for getting all the IAU-defined star names, is there a way to download a table of them? The WGSN website is not only extremely slow, it doesn't seem to provide any API to get the database. Also, it seems that Modern-IAU SC should then drop all its star names and set fallback to true. |
Shouldn't it have one, by definition of how such number is formed? Of course, XO-5 and friends are the newly-named exoplanet systems which are culturally irrelevant (apart from "pop culture") but still IAU approved...
Yes, the most perfect example! |
The database in
stellarium-skycultures
repo,common_names.tab
, contains more star names, and appears to mostly be a superset of those currently contained incommon_star_names.fab
, except minor differences in orthography. This PR adds a script and updates the names from that database.The nuance is that no references are kept, because if I write a number, it will refer to the external sky cultures repo, which seems not very good. Reference numbers are still present in that repo, in
common_names.tab
, referring to the actual references incommon_names_refs.tab
.