Enhance Rule SE-000007 by adding support for multiple extensions and …

…refactoring alert procedures
StefanMaron · Dec 4, 2024 · a2aa405 · a2aa405
1 parent 9376c8c
commit a2aa405
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/BusinessCentral.Sentinel/src/Rules/UnusedExtensionInstalled.Codeunit.al b/BusinessCentral.Sentinel/src/Rules/UnusedExtensionInstalled.Codeunit.al
@@ -14,9 +14,28 @@ codeunit 71180283 UnusedExtensionInstalledSESTM implements IAuditAlertSESTM
 
     procedure CreateAlerts()
     var
+        AMCBankingTok: Label '16319982-4995-4fb1-8fb2-2b1e13773e3b', Locked = true;
+        CeridianPayrollTok: Label '30828ce4-53e3-407f-ba80-13ce8d79d110', Locked = true;
+        CloudMigrationApiTok: Label '57623bfa-0559-4bc2-ae1c-0979c29fc8d1', Locked = true;
+        CloudMigrationTok: Label '6992416f-3f39-4d3c-8242-3fff61350bea', Locked = true;
+        IntelligentCloudTok: Label '334ef79e-547e-4631-8ba1-7a7f18e14de6', Locked = true;
+        IntercompanyAPITok: Label 'a190e87b-2f59-4e14-a727-421877802768', Locked = true;
         ShopifyConnectorIdTok: Label 'ec255f57-31d0-4ca2-b751-f2fa7c745abb', Locked = true;
     begin
-        RaiseAlertIfExtensionIsUnused(ShopifyConnectorIdTok, 30102); // Shopify Connector / Shops Table
+        RaiseAlertIfExtensionIsUnused(ShopifyConnectorIdTok, 30102);
+        RaiseAlertIfExtensionIsUnused(AMCBankingTok, 20101);
+        RaiseAlertIfExtensionIsUnused(IntercompanyAPITok, 413);
+        RaiseAlertIfExtensionIsUnused(CloudMigrationTok);
+        RaiseAlertIfExtensionIsUnused(CloudMigrationApiTok);
+        RaiseAlertIfExtensionIsUnused(IntelligentCloudTok);
+        RaiseAlertIfExtensionIsUnused(CeridianPayrollTok, 1665);
+    end;
+
+    local procedure RaiseAlertIfExtensionIsUnused(AppId: Text)
+    var
+        TablesToVerify: List of [Integer];
+    begin
+        RaiseAlertIfExtensionIsUnused(AppId, TablesToVerify);
     end;
 
     local procedure RaiseAlertIfExtensionIsUnused(AppId: Text; TableToVerify: Integer)

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,7 @@
 
 **Changes:**
 
+- Added extensions to Rule SE-000007: Shopify Connector, AMC Banking, API - Cross Environment Intercompany, Business Central Cloud Migration - Previous Release, Business Central Cloud Migration API, Business Central Intelligent Cloud, Ceridian Payroll
 - Adjusted rule SE-000007 to be more generic and not Shopify Connector specific
 - Fixed a bug that prevented the full rerun to work
 - Added Changelog